issue fix - modals/UrlModal: reset clicked state on close #1770
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevfurneaux
approved these changes
Feb 12, 2025
sevfurneaux
reviewed
Feb 12, 2025
| @@ -27,6 +27,10 @@ export const UrlModal = (props) => { | |||
| } | |||
| } | |||
|
|
|||
| const handleModalClose = () => { | |||
| setClicked(false) // Reset the clicked state when modal closes | |||
There was a problem hiding this comment.
Maybe we don't need a comment here if setClicked was renamed to make it more explicit what it is doing? Maybe setClosed. Although this is a slightly different type of modal, right? 🤔
There was a problem hiding this comment.
@sevfurneaux yes, the clicked state refers to the copy URL button. I could change it to setCopied—do you reckon that makes it clearer?
There was a problem hiding this comment.
Yeah, setCopied makes sense!
hom3mad3
force-pushed
the
mr-2025-02-fix-copy-on-close
branch
from
1ebe18f to
cc12393
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes liqd/a4-meinberlin#6062